fix(settings): use one member avatar with profile photos everywhere by waleedlatif1 · Pull Request #8221 · simstudioai/sim

waleedlatif1 · 2026-09-24T02:51:21Z

Summary

One member avatar everywhere: emcn Avatar gains name/src props (a discriminated union with composed children) — <Avatar size='xs' name={…} src={…} aria-hidden /> renders the person's photo, or their initial on the neutral disc, and a photo that fails to load falls back to the initial; no app-level wrapper
AvatarFallback sizes its glyph to the enclosing avatar (CVA, via context), so no caller overrides the font size; size-* classes and the --border token; empty names never produce an unlabelled role="img", and the status dot follows aria-hidden
Replaces five variants with it: the settings MemberAvatar and its duplicate OwnerAvatar (resource owner cells, owner filters), the 36px getUserColor avatar in the shared permissions member row (credential members, skill editors), the 32px colored avatar in the transfer-ownership dialog, and the 24px avatar in the credential-group people list
Photos now show where they were dropped: credential members select user.image (explicit and workspace-admin rows), skill editors pass the image the API already returned; the skills contract's userImage is tightened to nullable since both producers always set it
Avatars are aria-hidden — the name is always beside them
Updated the settings-pages rule that said to keep two avatar components; per-person colors stay only on live collaboration (presence, cursors)

Type of Change

Bug fix

Testing

Verified in the running app on Members, Teammates and Insights (photo and initial fallback, light and dark)
New tests: emcn Avatar in a real DOM — a loaded photo renders, a failed photo falls back to the initial, labelling and aria-hidden, per-size glyph; credential members carry images for explicit and derived rows
366 emcn tests and 7,514 app tests across the affected areas, lint, type-check, check:audits, docs-manifest, block registry green; /cleanup passes applied

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-24T02:51:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 3:37am UTC

greptile-apps · 2026-09-24T02:54:14Z

Confidence Score: 5/5

The PR appears safe to merge; no actionable new defects or outstanding previous findings remain.

Summary

The PR standardizes member and owner presentation on EMCN’s Avatar, carries profile-image data through credential and skill editor models, and adds DOM coverage for image fallback and accessibility behavior. Since the previous review, it also restores accessible status announcements for composed avatars and exports the fallback CVA variants.

Replaces duplicated avatar implementations across settings, permissions, ownership, and usage surfaces.
Adds image propagation for explicit and workspace-admin credential members.
Adds loaded-image, failed-image, sizing, labelling, hidden-avatar, and status accessibility tests.
All previous findings are resolved in the current code.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  MemberData[Member data] --> AvatarProps[name and optional src]
  AvatarProps --> Image{Photo loads?}
  Image -->|Yes| Photo[Profile photo]
  Image -->|No| Fallback[Initial fallback]
  AvatarProps --> Accessibility{aria-hidden?}
  Accessibility -->|No| Label[Accessible person label]
  Accessibility -->|Yes| Silent[Decorative avatar]
  Composed[Composed avatar with status] --> Status[Accessible status dot]

_{Reviews (4) · Last reviewed commit: "fix(emcn): keep a composed avatar's stat..."}

cubic-dev-ai

No issues found across 25 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

…c props

waleedlatif1 · 2026-09-24T03:05:48Z

@greptile

waleedlatif1 · 2026-09-24T03:05:49Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T03:05:56Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 28 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

…name on email-only rows

waleedlatif1 · 2026-09-24T03:27:16Z

@greptile

waleedlatif1 · 2026-09-24T03:27:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T03:27:22Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 28 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

…ack variants

waleedlatif1 · 2026-09-24T03:35:34Z

@greptile

waleedlatif1 · 2026-09-24T03:35:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T03:35:41Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 28 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

fix(settings): use one member avatar with profile photos everywhere

7800fb3

vercel Bot deployed to Preview September 24, 2026 02:53 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/components/member-avatar/member-avatar.test.tsx Outdated

improvement(emcn): collapse MemberAvatar into Avatar with name and sr…

7efb137

…c props

vercel Bot deployed to Preview September 24, 2026 03:07 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/member-list/member-list.tsx Outdated

Comment thread packages/emcn/src/components/avatar/avatar.tsx Outdated

fix(emcn): announce avatar status in the person's label and keep the …

0ee3ae1

…name on email-only rows

vercel Bot deployed to Preview September 24, 2026 03:29 View deployment

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread packages/emcn/src/components/avatar/avatar.tsx

Comment thread packages/emcn/src/components/avatar/avatar.tsx

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

fix(emcn): keep a composed avatar's status announced and export fallb…

fd1bfad

…ack variants

vercel Bot deployed to Preview September 24, 2026 03:37 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

waleedlatif1 merged commit 92d3b38 into staging Sep 24, 2026
37 checks passed

waleedlatif1 deleted the fix/settings-member-avatars branch September 24, 2026 03:42

Conversation

waleedlatif1 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

waleedlatif1 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading